From 450fdf0fe24f7acdfcac2e1b88fafd3b001d5e4c Mon Sep 17 00:00:00 2001
From: OlegTheSnowman <123775785+OlegTheSnowman@users.noreply.github.com>
Date: Sat, 11 Jul 2026 00:28:07 +0300
Subject: [PATCH] Fix Accelerator function-call bindings and jump-to-end false
 triggers

Accelerator(key, text) always sends text as a literal typed command -
it only calls a Lua function if a matching <alias> routes it there
(the pattern GagManager already used correctly). Several bindings
added this session skipped that step and were silently sending
gibberish to the MUD instead of running: Ctrl+S (save_state_func) in
CosmicRage.xml, Ctrl+Alt+J (toggle_jump_to_end) in output_functions.xml,
and Alt+Enter (toggle_numpad) in NumpadMovement.xml. Added the missing
aliases for all three.

Separately, poll_output_focus's jump-to-end was firing repeatedly even
while focus never changed: it compared Alien pointer returns with
"==", which is unreliable for Alien's userdata-wrapped pointers (two
separate calls returning the same real HWND don't reliably compare
equal). Switched to comparing tostring() output instead, which is
address-based. Debug log confirmed SmartAppendToNotepad's own
restore logic was correct throughout - this poll was the sole cause
of the "jumps to end when new text arrives" complaint.
---
 cosmic rage/worlds/plugins/CosmicRage.xml      | 11 +++++++++++
 cosmic rage/worlds/plugins/NumpadMovement.xml  | 17 ++++++++++++++++-
 .../worlds/plugins/output_functions.xml        | 18 +++++++++++++++++-
 3 files changed, 44 insertions(+), 2 deletions(-)

diff --git a/cosmic rage/worlds/plugins/CosmicRage.xml b/cosmic rage/worlds/plugins/CosmicRage.xml
index d263cf3..6f2f8e4 100644
--- a/cosmic rage/worlds/plugins/CosmicRage.xml	
+++ b/cosmic rage/worlds/plugins/CosmicRage.xml	
@@ -392,6 +392,17 @@ match="^\$sphook\s+(?P<action>[\w]+):(?P<path>[-\w./\\\s]+):(?P<volume>[\w]+):(?
 
 
 <aliases>
+  <alias
+   match="save_state_func"
+   enabled="y"
+   script="save_state_func"
+   omit_from_output="y"
+   omit_from_log="y"
+   omit_from_command_history="y"
+   send_to="12"
+   sequence="100"
+  >
+  </alias>
   <alias
    match="f11_stop"
    enabled="y"
diff --git a/cosmic rage/worlds/plugins/NumpadMovement.xml b/cosmic rage/worlds/plugins/NumpadMovement.xml
index c2d0257..48ff273 100644
--- a/cosmic rage/worlds/plugins/NumpadMovement.xml	
+++ b/cosmic rage/worlds/plugins/NumpadMovement.xml	
@@ -10,10 +10,25 @@
    language="Lua"
    purpose="Toggleable numpad movement, with Ctrl for up-movement and Ctrl+Alt for down-movement."
    requires="4.82"
-   version="1.0"
+   version="1.1"
    >
 </plugin>
 
+<!--  Aliases  -->
+<aliases>
+  <alias
+   match="toggle_numpad"
+   enabled="y"
+   script="toggle_numpad"
+   omit_from_output="y"
+   omit_from_log="y"
+   omit_from_command_history="y"
+   send_to="12"
+   sequence="100"
+  >
+  </alias>
+</aliases>
+
 <!--  Script  -->
 <script>
 <![CDATA[
diff --git a/cosmic rage/worlds/plugins/output_functions.xml b/cosmic rage/worlds/plugins/output_functions.xml
index e71e33c..7a2ff2c 100644
--- a/cosmic rage/worlds/plugins/output_functions.xml	
+++ b/cosmic rage/worlds/plugins/output_functions.xml	
@@ -170,6 +170,17 @@ omit_from_command_history="y"
 send_to="12"
 sequence="100">
 </alias>
+
+<alias
+match="toggle_jump_to_end"
+enabled="y"
+script="toggle_jump_to_end"
+omit_from_output="y"
+omit_from_log="y"
+omit_from_command_history="y"
+send_to="12"
+sequence="100">
+</alias>
 </aliases>
 
 <!--  Timers  -->
@@ -457,7 +468,12 @@ function poll_output_focus()
   return
  end
  local focused = GetFocus()
- local is_focused = (focused == edit)
+ -- Compare by string representation, not raw "==": Alien's pointer
+ -- returns are full userdata objects, so two separate calls returning
+ -- the same real HWND don't reliably compare equal with "==" (which
+ -- fell back to identity comparison), causing spurious "just gained
+ -- focus" edges and repeated jump-to-end even while focus never moved.
+ local is_focused = (tostring(focused) == tostring(edit))
  if is_focused and not was_output_focused then
   jump_notepad_to_end(edit)
  end